Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 146173004: Fix run-blink-httpd to work w/ Apache and refactor webkitpy.layout_tests.servers. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke
Modified:
6 years, 9 months ago
CC:
blink-reviews, Takashi Toyoshima
Visibility:
Public.

Description

Fix run-blink-httpd to work w/ Apache and refactor webkitpy.layout_tests.servers. This patch significantly cleans up the layout_tests/servers code to remove a bunch of stuff that was no longer being used, and also makes run-blink-httpd actually work again (though it no longer starts up the server as a daemon). R=scottmg@chromium.org, ojan@chromium.org, ukai@chromium.org, toyoshim@chromium.org BUG=30536

Patch Set 1 #

Patch Set 2 : add cli_wrapper and update run-* scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -1467 lines) Patch
M LayoutTests/http/conf/apache2-httpd.conf View 2 chunks +0 lines, -6 lines 0 comments Download
M Tools/Scripts/run-blink-httpd View 1 1 chunk +3 lines, -64 lines 0 comments Download
M Tools/Scripts/run-blink-websocketserver View 1 1 chunk +4 lines, -84 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 3 chunks +7 lines, -7 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/test.py View 1 chunk +1 line, -1 line 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py View 3 chunks +49 lines, -75 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py View 1 chunk +0 lines, -176 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py View 1 chunk +0 lines, -69 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py View 3 chunks +5 lines, -4 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper.py View 1 1 chunk +27 lines, -17 lines 0 comments Download
A Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper_unittest.py View 1 1 chunk +34 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/crash_service.py View 1 chunk +8 lines, -46 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py View 2 chunks +1 line, -2 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/http_server.py View 1 chunk +0 lines, -228 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py View 1 chunk +0 lines, -217 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py View 1 chunk +0 lines, -58 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py View 1 chunk +0 lines, -101 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/lighttpd.py View 5 chunks +14 lines, -98 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/lighttpd_unittest.py View 4 chunks +5 lines, -15 lines 0 comments Download
A Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py View 1 chunk +90 lines, -0 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/server_base.py View 4 chunks +39 lines, -18 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/server_base_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py View 1 chunk +0 lines, -175 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Takashi Toyoshima
move toyoshim from R to CC, and +tyoshino for R on pywebsocket
6 years, 10 months ago (2014-02-06 05:25:07 UTC) #1
tyoshino (SeeGerritForStatus)
websocket_server.py -> pywebsocket.py lgtm Memo: Old reason for use of devnull http://trac.webkit.org/changeset/56614
6 years, 10 months ago (2014-02-06 09:33:56 UTC) #2
Dirk Pranke
On 2014/02/06 09:33:56, tyoshino wrote: > websocket_server.py -> pywebsocket.py lgtm > > Memo: Old reason ...
6 years, 10 months ago (2014-02-06 19:04:19 UTC) #3
Dirk Pranke
6 years, 9 months ago (2014-02-26 21:23:59 UTC) #4
Message was sent while issue was closed. 
closing ... this patch was split up and all the pieces have landed.

Powered by Google App Engine
This is Rietveld 408576698