components/webcrypto/algorithms/sha.cc - Issue 1461703009: Switch //components from vector_as_array to vector::data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webcrypto/algorithms/sha.cc

Issue 1461703009: Switch //components from vector_as_array to vector::data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/webcrypto/algorithms/rsa_oaep_unittest.cc ('K') | « components/webcrypto/algorithms/secret_key_util.cc ('k') | components/webcrypto/algorithms/sha_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/webcrypto/algorithms/sha.cc

diff --git a/components/webcrypto/algorithms/sha.cc b/components/webcrypto/algorithms/sha.cc

index 2d8b544b5453ccf387fe6ceb1b709511777908e9..69135cff09d7de1cf9f9abf11dbb82bf476e669b 100644

--- a/components/webcrypto/algorithms/sha.cc

+++ b/components/webcrypto/algorithms/sha.cc

@@ -7,7 +7,6 @@

#include <vector>

#include "base/logging.h"

-#include "base/stl_util.h"

#include "components/webcrypto/algorithm_implementation.h"

#include "components/webcrypto/algorithms/util.h"

#include "components/webcrypto/crypto_data.h"

@@ -58,9 +57,8 @@ class DigestorImpl : public blink::WebCryptoDigestor {

Status FinishWithVectorAndStatus(std::vector<uint8_t>* result) {

const int hash_expected_size = EVP_MD_CTX_size(digest_context_.get());

result->resize(hash_expected_size);

- unsigned char* const hash_buffer = vector_as_array(result);

unsigned int hash_buffer_size; // ignored

- return FinishInternal(hash_buffer, &hash_buffer_size);

+ return FinishInternal(result->data(), &hash_buffer_size);

}

private: