components/webcrypto/algorithms/rsa_ssa_unittest.cc - Issue 1461703009: Switch //components from vector_as_array to vector::data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webcrypto/algorithms/rsa_ssa_unittest.cc

Issue 1461703009: Switch //components from vector_as_array to vector::data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/webcrypto/algorithms/rsa_oaep_unittest.cc ('K') | « components/webcrypto/algorithms/rsa_sign.cc ('k') | components/webcrypto/algorithms/secret_key_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/webcrypto/algorithms/rsa_ssa_unittest.cc

diff --git a/components/webcrypto/algorithms/rsa_ssa_unittest.cc b/components/webcrypto/algorithms/rsa_ssa_unittest.cc

index 31cc967b3862b2de35271f559d7b4084da237515..360bdb98170a364a4115bac503260c2cf156c9b0 100644

--- a/components/webcrypto/algorithms/rsa_ssa_unittest.cc

+++ b/components/webcrypto/algorithms/rsa_ssa_unittest.cc

@@ -3,7 +3,6 @@

// found in the LICENSE file.

#include "base/logging.h"

-#include "base/stl_util.h"

#include "base/values.h"

#include "components/webcrypto/algorithm_dispatch.h"

#include "components/webcrypto/algorithms/test_helpers.h"

@@ -546,7 +545,7 @@ TEST_F(WebCryptoRsaSsaTest, SignVerifyFailures) {

// Ensure truncated signature does not verify by passing one less byte.

EXPECT_EQ(Status::Success(),

Verify(algorithm, public_key,

- CryptoData(vector_as_array(&signature),

+ CryptoData(signature.data(),

static_cast<unsigned int>(signature.size()) - 1),

CryptoData(data), &signature_match));

EXPECT_FALSE(signature_match);