components/webcrypto/algorithms/rsa.cc - Issue 1461703009: Switch //components from vector_as_array to vector::data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webcrypto/algorithms/rsa.cc

Issue 1461703009: Switch //components from vector_as_array to vector::data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/webcrypto/algorithms/ecdsa.cc ('K') | « components/webcrypto/algorithms/pbkdf2.cc ('k') | components/webcrypto/algorithms/rsa_oaep.cc » ('j') | components/webcrypto/algorithms/rsa_oaep_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/webcrypto/algorithms/rsa.cc

diff --git a/components/webcrypto/algorithms/rsa.cc b/components/webcrypto/algorithms/rsa.cc

index e789d2921f8aa8fb1e4e6416dc2d408a55c21412..888b1577f30d6d707a6f9835bf27375d38754f33 100644

--- a/components/webcrypto/algorithms/rsa.cc

+++ b/components/webcrypto/algorithms/rsa.cc

@@ -7,7 +7,6 @@

#include <openssl/evp.h>

#include "base/logging.h"

-#include "base/stl_util.h"

#include "components/webcrypto/algorithms/asymmetric_key_util.h"

#include "components/webcrypto/algorithms/util.h"

#include "components/webcrypto/blink_key_handle.h"

@@ -232,7 +231,7 @@ Status ImportRsaPublicKey(const blink::WebCryptoAlgorithm& algorithm,

// Converts a BIGNUM to a big endian byte array.

std::vector<uint8_t> BIGNUMToVector(const BIGNUM* n) {

std::vector<uint8_t> v(BN_num_bytes(n));

- BN_bn2bin(n, vector_as_array(&v));

+ BN_bn2bin(n, v.data());

return v;

}