Switch //components from vector_as_array to vector::data.

components/webcrypto/algorithms/rsa_oaep_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base64url.h"
 #include "base/logging.h"
-#include "base/stl_util.h"
 #include "components/webcrypto/algorithm_dispatch.h"
 #include "components/webcrypto/algorithms/test_helpers.h"
 #include "components/webcrypto/crypto_data.h"
 #include "components/webcrypto/jwk.h"
 #include "components/webcrypto/status.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h"
 #include "third_party/WebKit/public/platform/WebCryptoKeyAlgorithm.h"
 
 namespace webcrypto {
 
 namespace {
 
 // Creates an RSA-OAEP algorithm
 blink::WebCryptoAlgorithm CreateRsaOaepAlgorithm(
     const std::vector<uint8_t>& label) {
   return blink::WebCryptoAlgorithm::adoptParamsAndCreate(
       blink::WebCryptoAlgorithmIdRsaOaep,
       new blink::WebCryptoRsaOaepParams(
-          !label.empty(), vector_as_array(&label),
+          !label.empty(), label.data(),
           static_cast<unsigned int>(label.size())));
 }
 
 std::string Base64EncodeUrlSafe(const std::vector<uint8_t>& input) {
   // The JSON web signature spec says that padding is omitted.
   // https://tools.ietf.org/html/draft-ietf-jose-json-web-signature-36#section-2
   std::string base64url_encoded;
   base::Base64UrlEncode(
-      base::StringPiece(reinterpret_cast<const char*>(vector_as_array(&input)),
+      base::StringPiece(reinterpret_cast<const char*>(input.data()),

[eroman, 2015/11/20 00:35:14]

side note: wonder if we should have an automatic thing for building StringPiece
given std::vector of bytes. 
Or maybe more generally any std container whose valuetype is 1 byte large.

[davidben, 2015/11/20 19:12:50]

Yeah, we certainly need something. Doing these reinterpret_casts is awful. A
uint8_t StringPiece is an option.

I'll never forgive C for making char signed[*]. That was a horrible idea.

[*] It's not even signed. It's implementation-specific whether it's signed or
unsigned!

                         input.size()),
       base::Base64UrlEncodePolicy::OMIT_PADDING, &base64url_encoded);
   return base64url_encoded;
 }
 
 scoped_ptr<base::DictionaryValue> CreatePublicKeyJwkDict() {
   scoped_ptr<base::DictionaryValue> jwk(new base::DictionaryValue());
   jwk->SetString("kty", "RSA");
   jwk->SetString("n",
                  Base64EncodeUrlSafe(HexStringToBytes(kPublicKeyModulusHex)));
@@ skipping 460 matching lines @@
     EXPECT_TRUE(public_key2.extractable());
     EXPECT_EQ(import_algorithm.id(), public_key2.algorithm().id());
 
     // TODO(eroman): Export the SPKI and verify matches.
   }
 }
 
 }  // namespace
 
 }  // namespace webcrypto