Switch //components from vector_as_array to vector::data.

components/gcm_driver/crypto/p256_key_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/gcm_driver/crypto/p256_key_util.h"
 
 #include <stdint.h>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/stl_util.h"
 #include "crypto/ec_private_key.h"
 
 namespace gcm {
 
 namespace {
 
 // The first byte in an uncompressed P-256 point per SEC1 2.3.3.
 const char kUncompressedPointForm = 0x04;
 
 // A P-256 field element consists of 32 bytes.
@@ skipping 42 matching lines @@
   std::vector<uint8_t> public_key_x509;
 
   // Export the public key to an X.509 SubjectPublicKeyInfo for enabling NSS to
   // import the key material when computing a shared secret.
   if (!key_pair->ExportPublicKey(&public_key_x509)) {
     DLOG(ERROR) << "Unable to export the public key as an X.509 "
                 << "SubjectPublicKeyInfo block.";
     return false;
   }
 
-  out_private_key->assign(
-      reinterpret_cast<const char*>(vector_as_array(&private_key)),
-      private_key.size());
+  out_private_key->assign(reinterpret_cast<const char*>(private_key.data()),

[eroman, 2015/11/20 00:35:14]

Any reason not to use:
  out_private_key->assign(private_key.begin(), private_key.end());

I tried locally and it didn't complain about the signed/unsigned conversion, but
might be MSVC does, dunno.

[davidben, 2015/11/20 19:12:50]

That works? Hrm. We do this (ugly) reinterpret_cast thing everywhere, so let's
experiment with that separately. I could imagine dumb things happen like, I
dunno, the iterator version of assign being written to not assume you can
compare the iterators for size.

+                          private_key.size());
   out_public_key_x509->assign(
-      reinterpret_cast<const char*>(vector_as_array(&public_key_x509)),
+      reinterpret_cast<const char*>(public_key_x509.data()),

[eroman, 2015/11/20 00:35:14]

same question throughout.

[davidben, 2015/11/20 19:12:50]

Acknowledged.

       public_key_x509.size());
 
   // Concatenate the leading 0x04 byte and the two uncompressed points.
   out_public_key->reserve(kUncompressedPointBytes);
   out_public_key->push_back(kUncompressedPointForm);
   out_public_key->append(candidate_public_key);
 
   return true;
 }
 
 }  // namespace gcm