test/Transforms/NaCl/rewrite-longjmp-no-store.ll - Issue 14617017: Adding a pass - RewritePNaClLibraryCalls, that replaces known library calls with stable bitcode int…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/Transforms/NaCl/rewrite-longjmp-no-store.ll

Issue 14617017: Adding a pass - RewritePNaClLibraryCalls, that replaces known library calls with stable bitcode int… (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master

Patch Set: Added llvm.nacl.{set|long}jmp to the list of whitelisted intrinsics for ABI Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« lib/Transforms/NaCl/RewritePNaClLibraryCalls.cpp ('K') | « lib/Transforms/NaCl/RewritePNaClLibraryCalls.cpp ('k') | test/Transforms/NaCl/rewrite-longjmp-noncall-uses.ll » ('j') | test/Transforms/NaCl/rewrite-longjmp-noncall-uses.ll » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 ; RUN: opt < %s -rewrite-pnacl-library-calls -S \| FileCheck %s

	2 ; Test that when there's no store of longjmp's address, no function

	3 ; body is generated.

	4

	5 declare void @longjmp(i64*, i32)

	6 ; CHECK-NOT: define internal void @longjmp(i64* %env, i32 %val) {
	Mark Seaborn 2013/05/13 23:39:58 Maybe make this stricter: ; CHECK-NOT: define{{.} Maybe make this stricter: ; CHECK-NOT: define{{.}}@longjmp( eliben 2013/05/14 17:38:58 Done. Show quoted text On 2013/05/13 23:39:58, Mark Seaborn wrote: > Maybe make this stricter: > ; CHECK-NOT: define{{.*}}@longjmp( Done.
	7

	8 define void @call_longjmp(i64* %arg, i32 %num) {

	9 call void @longjmp(i64* %arg, i32 %num)

	10 ; CHECK: call void @llvm.nacl.longjmp(i8* %jmp_buf_i8, i32 %num)
	Mark Seaborn 2013/05/13 23:39:58 Maybe check for the bitcast too? Oh, I see rewrit Maybe check for the bitcast too? Oh, I see rewrite-setlongjmp-calls.ll checks for the bitcast.
	11 ret void

	12 }

	13

OLD	NEW