Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 14617015: Consistently assume that arithmetic operations can overflow unless one can prove the opposite. (Closed)

Created:
7 years, 7 months ago by Sven Panne
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Consistently assume that arithmetic operations can overflow unless one can prove the opposite. Previously, HDiv never had its CanOverflow flag cleared and HMod had inverted logic (compared to HAdd, HSub and HMul). Minor cleanups on the way. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14644

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M src/hydrogen-instructions.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 3 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 7 months ago (2013-05-10 14:53:07 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-13 13:29:06 UTC) #2
Sven Panne
7 years, 7 months ago (2013-05-13 13:48:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14644 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698