src/hydrogen-instructions.cc - Issue 14617014: Fixed constant folding in HMod.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 14617014: Fixed constant folding in HMod. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased. Fixed unit test. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index f38fb7d5e3d4312383c198cf23b25a7cf2f8f602..2b525159b0ba2be12d386e718c4c0377f33a5448 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -3341,6 +3341,9 @@ HInstruction* HMod::New(

if (c_left->HasInteger32Value() && c_right->HasInteger32Value()) {

int32_t dividend = c_left->Integer32Value();

int32_t divisor = c_right->Integer32Value();

+ if (dividend == kMinInt && divisor == -1) {

+ return H_CONSTANT_DOUBLE(-0.0);

+ }

if (divisor != 0) {

int32_t res = dividend % divisor;

if ((res == 0) && (dividend < 0)) {

« no previous file with comments | « no previous file | test/mjsunit/constant-folding-2.js » ('j') | no next file with comments »