Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/app/chrome_exe_main_win.cc

Issue 14617003: Make chrome.exe rendezvous with existing chrome process earlier. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: respond to comments, add whitelist, add policy check for udd Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <windows.h> 5 #include <windows.h>
6 #include <tchar.h> 6 #include <tchar.h>
7 7
8 #include <string>
9
8 #include "base/at_exit.h" 10 #include "base/at_exit.h"
9 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/files/file_path.h"
10 #include "chrome/app/breakpad_win.h" 13 #include "chrome/app/breakpad_win.h"
11 #include "chrome/app/client_util.h" 14 #include "chrome/app/client_util.h"
12 #include "chrome/app/metro_driver_win.h" 15 #include "chrome/app/metro_driver_win.h"
16 #include "chrome/browser/chrome_process_finder_win.h"
17 #include "chrome/browser/policy/policy_path_parser.h"
18 #include "chrome/common/chrome_paths_internal.h"
19 #include "chrome/common/chrome_switches.h"
13 #include "content/public/app/startup_helper_win.h" 20 #include "content/public/app/startup_helper_win.h"
14 #include "content/public/common/result_codes.h" 21 #include "content/public/common/result_codes.h"
15 #include "sandbox/win/src/sandbox_factory.h" 22 #include "sandbox/win/src/sandbox_factory.h"
16 23
17 int RunChrome(HINSTANCE instance) { 24 int RunChrome(HINSTANCE instance) {
18 bool exit_now = true; 25 bool exit_now = true;
19 // We restarted because of a previous crash. Ask user if we should relaunch. 26 // We restarted because of a previous crash. Ask user if we should relaunch.
20 if (ShowRestartDialogIfCrashed(&exit_now)) { 27 if (ShowRestartDialogIfCrashed(&exit_now)) {
21 if (exit_now) 28 if (exit_now)
22 return content::RESULT_CODE_NORMAL_EXIT; 29 return content::RESULT_CODE_NORMAL_EXIT;
23 } 30 }
24 31
25 // Initialize the sandbox services. 32 // Initialize the sandbox services.
26 sandbox::SandboxInterfaceInfo sandbox_info = {0}; 33 sandbox::SandboxInterfaceInfo sandbox_info = {0};
27 content::InitializeSandboxInfo(&sandbox_info); 34 content::InitializeSandboxInfo(&sandbox_info);
28 35
29 // Load and launch the chrome dll. *Everything* happens inside. 36 // Load and launch the chrome dll. *Everything* happens inside.
30 MainDllLoader* loader = MakeMainDllLoader(); 37 MainDllLoader* loader = MakeMainDllLoader();
31 int rc = loader->Launch(instance, &sandbox_info); 38 int rc = loader->Launch(instance, &sandbox_info);
32 loader->RelaunchChromeBrowserWithNewCommandLineIfNeeded(); 39 loader->RelaunchChromeBrowserWithNewCommandLineIfNeeded();
33 delete loader; 40 delete loader;
34 return rc; 41 return rc;
35 } 42 }
36 43
44 // List of switches that it's safe to rendezvous early with.
45 const std::string kFastStartSwitches[] = {
46 switches::kShowAppList,
47 };
48
49 bool IsFastStartSwitch(const std::string& command_line_switch) {
50 for (size_t i = 0; i < arraysize(kFastStartSwitches); i++)
pastarmovj 2013/05/09 09:53:32 nit: You can use std::find here. E.g: std::string*
koz (OOO until 15th September) 2013/05/10 01:46:48 Done.
51 if (kFastStartSwitches[i] == command_line_switch)
52 return true;
53 return false;
54 }
55
56 bool ContainsNonFastStartFlag(CommandLine* command_line) {
57 const CommandLine::SwitchMap& switches = command_line->GetSwitches();
58 for (CommandLine::SwitchMap::const_iterator it = switches.begin();
59 it != switches.end(); it++) {
60 if (!IsFastStartSwitch(it->first))
61 return true;
62 }
63 return false;
64 }
65
66 bool AttemptFastNotify(CommandLine* command_line) {
67 if (ContainsNonFastStartFlag(command_line))
68 return false;
69
70 base::FilePath user_data_dir;
71 if (!chrome::GetDefaultUserDataDirectory(&user_data_dir))
72 return false;
73 policy::path_parser::CheckUserDataDirPolicy(&user_data_dir);
74
75 HWND chrome = chrome::FindRunningChromeWindow(user_data_dir);
76 if (chrome && chrome::AttemptToNotifyRunningChrome(chrome))
77 return true;
78 return false;
79 }
80
37 int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE prev, wchar_t*, int) { 81 int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE prev, wchar_t*, int) {
38 // Initialize the commandline singleton from the environment. 82 // Initialize the commandline singleton from the environment.
39 CommandLine::Init(0, NULL); 83 CommandLine::Init(0, NULL);
40 // The exit manager is in charge of calling the dtors of singletons. 84 // The exit manager is in charge of calling the dtors of singletons.
41 base::AtExitManager exit_manager; 85 base::AtExitManager exit_manager;
42 86
87 if (AttemptFastNotify(CommandLine::ForCurrentProcess()))
88 return 0;
89
43 MetroDriver metro_driver; 90 MetroDriver metro_driver;
44 if (metro_driver.in_metro_mode()) 91 if (metro_driver.in_metro_mode())
45 return metro_driver.RunInMetro(instance, &RunChrome); 92 return metro_driver.RunInMetro(instance, &RunChrome);
46 // Not in metro mode, proceed as normal. 93 // Not in metro mode, proceed as normal.
47 return RunChrome(instance); 94 return RunChrome(instance);
48 } 95 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chrome_process_finder_win.h » ('j') | chrome/browser/chrome_process_finder_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698