[headless] Initial skeleton of headless/public/

headless/public/headless_browser.cc

Index: headless/public/headless_browser.cc
diff --git a/headless/public/headless_browser.cc b/headless/public/headless_browser.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6f5cc57b74c2ef345aa6b975eba5d061bffebb6d
--- /dev/null
+++ b/headless/public/headless_browser.cc
@@ -0,0 +1,46 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.

[Sami, 2015/12/01 17:48:27]

I think this file should be headless/src/? (it used to be lib but turns out src
is more correct.)

[altimin, 2015/12/01 18:42:46]

I followed example of content/public/, where public directory contains headers
and occasional .cc files and other directories contain implementations.

[Sami, 2015/12/01 18:53:53]

I see. I wonder where we should draw the line. For a user of the headless
library it would be very confusing to me to see any .cc files in this directory,
so maybe this is a bit of a special case.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "headless/public/headless_browser.h"
+
+using Options = headless::HeadlessBrowser::Options;
+using Builder = headless::HeadlessBrowser::Options::Builder;
+
+namespace headless {
+
+Options::Options(int argc, const char** argv)
+    : argc(argc), argv(argv), devtools_http_port(kInvalidPort) {}
+
+Options::Options(Options&& options) {
+  *this = options;

[Sami, 2015/12/01 17:47:33]

nit: the documentation seems to suggest that we do need the std::move() here:

https://www.chromium.org/rvalue-references#TOC-9.-Move-constructors-should-be....

[altimin, 2015/12/01 18:42:46]

Done.

+}
+
+Options::~Options() {}
+
+Builder::Builder(int argc, const char** argv) : options_(argc, argv) {}
+
+Builder::~Builder() {}
+
+Builder& Builder::SetUserAgent(const std::string& user_agent) {
+  options_.user_agent = user_agent;
+  return *this;
+}
+
+Builder& Builder::EnableDevToolsServer(int port) {
+  options_.devtools_http_port = port;
+  return *this;
+}
+
+Builder& Builder::SetURLRequestContextGetter(
+    scoped_refptr<net::URLRequestContextGetter> url_request_context_getter) {
+  options_.url_request_context_getter = url_request_context_getter;
+  return *this;
+}
+
+Options Builder::Build() {
+  return options_;
+  //  return std::move(options_);

[Sami, 2015/12/01 17:47:33]

Bad edit?

[altimin, 2015/12/01 18:42:46]

Indeed, thanks.

+}
+
+}  // namespace headless