[headless] Initial skeleton of headless/public/

headless/public/headless_browser.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef HEADLESS_PUBLIC_HEADLESS_BROWSER_H_
+#define HEADLESS_PUBLIC_HEADLESS_BROWSER_H_
+
+#include "base/callback.h"
+#include "base/memory/ref_counted.h"
+
+namespace base {
+class SingleThreadTaskRunner;
+
+namespace trace_event {
+class TraceConfig;
+}
+}
+
+namespace headless {
+class WebContents;
+
+class HeadlessBrowser {

[Sami, 2015/11/19 14:08:34]

I think we need a HEADLESS_EXPORT macro on all the classes here (see for example
https://code.google.com/p/chromium/codesearch#chromium/src/components/schedul...)

[altimin, 2015/11/19 14:52:54]

Done.

+ public:
+  static HeadlessBrowser* Get();

[Sami, 2015/11/19 14:08:34]

Could you add some documentation comments for the methods here and in
WebContents? The DOM parts will still change so let's document them later.

[altimin, 2015/11/19 14:52:54]

Done.

+
+  virtual WebContents* CreateWebContents(int width, int height) = 0;

[Sami, 2015/11/19 14:08:34]

Return a scoped_ptr here. gfx::Size instead of width/height?

[altimin, 2015/11/19 14:52:54]

Done.

+
+  virtual scoped_refptr<base::SingleThreadTaskRunner> browser_main_thread() = 0;
+  virtual scoped_refptr<base::SingleThreadTaskRunner>
+  renderer_main_thread() = 0;
+
+  virtual int Run(int argc, const char** argv) = 0;
+  virtual void Stop() = 0;
+
+  virtual void OnStart(const base::Closure& on_start_callback) = 0;

[Sami, 2015/11/19 14:08:34]

Is this something the client would call? Maybe we can think of some better name
for this since it's a little unclear what this does.

[altimin, 2015/11/19 14:52:54]

We want to give user an ability to do some work as browser starts (open pages
etc). This is the function to register callback to be executed as soon as
browser starts.

[Sami, 2015/11/19 15:42:44]

Should we just have the user pass this into Run? Seems like you would always
want to use this.

[altimin, 2015/11/19 16:13:13]

Done.

+
+  virtual void TracingStartRecording(

[Sami, 2015/11/19 14:08:34]

Probably best to leave tracing out for now since I'm not sure what the best
shape for this API is yet.

[altimin, 2015/11/19 14:52:54]

Done.

+      const base::trace_event::TraceConfig& trace_config) = 0;
+  virtual void TracingStopRecording(const std::string& log_file_name) = 0;
+
+ protected:
+  virtual ~HeadlessBrowser(){};

[Sami, 2015/11/19 14:08:34]

nit: space missing before {} (did you run git cl format?)

[altimin, 2015/11/19 14:52:54]

Yes! And git cl format does exactly this.

+};
+
+}  // namespace headless
+
+#endif  // HEADLESS_PUBLIC_HEADLESS_BROWSER_H_