chrome/browser/ui/views/toolbar/toolbar_button.cc - Issue 1461673002: Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and Views::SchedulePaint().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 1461673002: Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and Views::SchedulePaint(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added ViewLayerTests to check paints scheduled on the parent. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/toolbar_button.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc

index 808e450ab02544f0e0ca7a8870b5297cc3cfd350..7627bafdb519caedcb499a484795bf515448d8b5 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc

@@ -230,10 +230,6 @@ void ToolbarButton::AddInkDropLayer(ui::Layer* ink_drop_layer) {

layer()->Add(ink_drop_layer);

layer()->StackAtBottom(ink_drop_layer);

- // Invalidates the contents of the parent's layer which may contain

- // a stale close/reload icon that should not remain visible.

- parent()->SchedulePaint();

}

void ToolbarButton::RemoveInkDropLayer(ui::Layer* ink_drop_layer) {

« no previous file with comments | « no previous file | ui/views/view.h » ('j') | ui/views/view.cc » ('J')