Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and Views::SchedulePaint().

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 #include <cmath>
@@ skipping 434 matching lines @@
 void View::SetTransform(const gfx::Transform& transform) {
   if (transform.IsIdentity()) {
     if (layer()) {
       layer()->SetTransform(transform);
       if (!paint_to_layer_)
         DestroyLayer();
     } else {
       // Nothing.
     }
   } else {
-    if (!layer())
+    if (!layer()) {
       CreateLayer();
+      // TODO(bruthig): Should a paint be scheduled on the parent here?
+    }
     layer()->SetTransform(transform);
     layer()->ScheduleDraw();
   }
 }
 
 void View::SetPaintToLayer(bool paint_to_layer) {
   if (paint_to_layer_ == paint_to_layer)
     return;
 
   paint_to_layer_ = paint_to_layer;
   if (paint_to_layer_ && !layer()) {
     CreateLayer();
+    // The parent layer may be dirty due to a previous paint by |this|.
+    SchedulePaintOnParent();

[sky, 2015/12/27 23:55:04]

I think you should move this to CreateLayer, just as DestoryLayer does the
paint.

[bruthig, 2016/01/04 19:00:15]

Done.

   } else if (!paint_to_layer_ && layer()) {
     DestroyLayer();
   }
 }
 
 scoped_ptr<ui::Layer> View::RecreateLayer() {
   scoped_ptr<ui::Layer> old_layer = LayerOwner::RecreateLayer();
   Widget* widget = GetWidget();
   if (widget)
     widget->UpdateRootLayers();
@@ skipping 932 matching lines @@
                  "width", canvas->sk_canvas()->getBaseLayerSize().width(),
                  "height", canvas->sk_canvas()->getBaseLayerSize().height());
     border_->Paint(*this, canvas);
   }
 }
 
 // Accelerated Painting --------------------------------------------------------
 
 void View::SetFillsBoundsOpaquely(bool fills_bounds_opaquely) {
   // This method should not have the side-effect of creating the layer.
-  if (layer())
-    layer()->SetFillsBoundsOpaquely(fills_bounds_opaquely);
+  if (!layer() || layer()->fills_bounds_opaquely() == fills_bounds_opaquely)
+    return;
+
+  layer()->SetFillsBoundsOpaquely(fills_bounds_opaquely);
+  if (!fills_bounds_opaquely)
+    SchedulePaintOnParent();

[sky, 2015/12/27 23:55:04]

I'm not following why this needed. If it is needed, why isn't it always needed?

[bruthig, 2016/01/04 19:00:15]

Removed, I talked with ajuma@ about layers and this should not be required.

 }
 
 gfx::Vector2d View::CalculateOffsetToAncestorWithLayer(
     ui::Layer** layer_parent) {
   if (layer()) {
     if (layer_parent)
       *layer_parent = layer();
     return gfx::Vector2d();
   }
   if (!parent_)
@@ skipping 327 matching lines @@
     SchedulePaint();
   } else if (parent_ && type == SCHEDULE_PAINT_SIZE_SAME) {
     // The compositor doesn't Draw() until something on screen changes, so
     // if our position changes but nothing is being animated on screen, then
     // tell the compositor to redraw the scene. We know layer() exists due to
     // the above if clause.
     layer()->ScheduleDraw();
   }
 }
 
+void View::SchedulePaintOnParent() {
+  if (parent_) {
+    // Translate the requested paint rect to the parent's coordinate system
+    // then pass this notification up to the parent.
+    parent_->SchedulePaintInRect(ConvertRectToParent(GetLocalBounds()));
+  }
+}
+
 // Tree operations -------------------------------------------------------------
 
 void View::DoRemoveChildView(View* view,
                              bool update_focus_cycle,
                              bool update_tool_tip,
                              bool delete_removed_view,
                              View* new_parent) {
   DCHECK(view);
 
   const Views::iterator i(std::find(children_.begin(), children_.end(), view));
@@ skipping 608 matching lines @@
   // Message the RootView to do the drag and drop. That way if we're removed
   // the RootView can detect it and avoid calling us back.
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   widget->RunShellDrag(this, data, widget_location, drag_operations, source);
   // WARNING: we may have been deleted.
   return true;
 }
 
 }  // namespace views