Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1461663003: Add SkRecord::defrag(). (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SkRecord::defrag(). Called by SkRecordOptimize(), this moves all the NoOps to the end and slices them off. This implementation with std::remove_if() is linear and doesn't malloc. No diffs: https://gold.skia.org/search2?issue=1461663003&unt=true&query=source_type%3Dgm&master=false BUG=skia: Committed: https://skia.googlesource.com/skia/+/c3c6194ba2b90fde57d8d0bc1d6302656f0dae27

Patch Set 1 #

Patch Set 2 : remove_if #

Patch Set 3 : simplify #

Patch Set 4 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M src/core/SkRecord.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkRecord.cpp View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M src/core/SkRecordOpts.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/RecordTest.cpp View 1 2 3 2 chunks +23 lines, -3 lines 0 comments Download
M tests/RecordTestUtils.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461663003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461663003/60001
5 years, 1 month ago (2015-11-18 22:50:13 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 23:01:48 UTC) #4
mtklein_C
5 years, 1 month ago (2015-11-18 23:29:32 UTC) #6
reed1
lgtm
5 years, 1 month ago (2015-11-19 15:07:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461663003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461663003/60001
5 years, 1 month ago (2015-11-19 15:11:03 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 15:23:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c3c6194ba2b90fde57d8d0bc1d6302656f0dae27

Powered by Google App Engine
This is Rietveld 408576698