Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1461653002: Use invalidation sets for :unresolved. (Closed)

Created:
5 years, 1 month ago by rune
Modified:
5 years, 1 month ago
Reviewers:
hayato, Eric Willigers
CC:
chromium-reviews, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use invalidation sets for :unresolved. Gets rid of SubtreeStyleChange which relies on sibling tree recalcs. Added TODO with issue for :default which just doesn't trigger any updates from the DOM side. R=hayato@chromium.org,ericwilligers@chromium.org BUG=557440 Committed: https://crrev.com/111bc9ca2386a56cf662eff2cebd97f35dff6880 Cr-Commit-Position: refs/heads/master@{#360537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/unresolved-pseudo.html View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/invalidation/unresolved-pseudo-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461653002/1
5 years, 1 month ago (2015-11-18 15:49:13 UTC) #2
rune
ptal
5 years, 1 month ago (2015-11-18 15:49:20 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 17:34:57 UTC) #5
hayato
lgtm
5 years, 1 month ago (2015-11-19 01:32:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461653002/1
5 years, 1 month ago (2015-11-19 06:47:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 06:51:20 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/111bc9ca2386a56cf662eff2cebd97f35dff6880 Cr-Commit-Position: refs/heads/master@{#360537}
5 years, 1 month ago (2015-11-19 06:52:20 UTC) #10
Eric Willigers
5 years, 1 month ago (2015-11-20 01:36:08 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698