Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1461643002: Initialize member variables of ui::ScrollEvent (Closed)

Created:
5 years, 1 month ago by jsokol
Modified:
5 years, 1 month ago
Reviewers:
ananta, sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize member variables of ui::ScrollEvent With current implementation of GetScrollOffsets on Windows, none values are changed and remain garbage. To make sure none of this will lead to crash, just initialize values with zeros. BUG= Committed: https://crrev.com/70763eb93a32555910a3b4269aeec51252ab9ec6 Cr-Commit-Position: refs/heads/master@{#360389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/events/event.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jsokol
Hi, Here's a minor patch we've prepared in Opera when we had discovered several reports ...
5 years, 1 month ago (2015-11-18 15:35:29 UTC) #2
sadrul
lgtm
5 years, 1 month ago (2015-11-18 18:17:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461643002/1
5 years, 1 month ago (2015-11-18 18:21:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 19:42:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 19:44:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70763eb93a32555910a3b4269aeec51252ab9ec6
Cr-Commit-Position: refs/heads/master@{#360389}

Powered by Google App Engine
This is Rietveld 408576698