Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 1461633002: Clean up dead code: render_pdfs. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up dead code: render_pdfs. DM can do this. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f970ad6ee1161bc99bcdeed511498d6d4e9531b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -337 lines) Patch
M gyp/tools.gyp View 2 chunks +0 lines, -56 lines 0 comments Download
D tools/render_pdfs_main.cpp View 1 chunk +0 lines, -281 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 1 month ago (2015-11-18 14:03:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461633002/1
5 years, 1 month ago (2015-11-18 14:03:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 14:16:10 UTC) #6
hal.canary
lgtm
5 years, 1 month ago (2015-11-18 14:38:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461633002/1
5 years, 1 month ago (2015-11-18 14:38:19 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 14:39:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f970ad6ee1161bc99bcdeed511498d6d4e9531b0

Powered by Google App Engine
This is Rietveld 408576698