third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 1461623002: Disable stretch-to-viewport quirk for multicol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1461623002: Disable stretch-to-viewport quirk for multicol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/multicol-on-root-element-quirks-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index 896c08f34e1ae5756bbb6551e8ea3ef892c939a0..07c0d2c66265cdab8da27312202509a664420384 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -621,10 +621,7 @@ public:

void computeLogicalWidth(LogicalExtentComputedValues&) const;

- bool stretchesToViewport() const

- {

- return document().inQuirksMode() && style()->logicalHeight().isAuto() && !isFloatingOrOutOfFlowPositioned() && (isDocumentElement() || isBody()) && !isInline();

- }

+ bool stretchesToViewport() const { return document().inQuirksMode() && stretchesToViewportInQuirksMode(); }

virtual LayoutSize intrinsicSize() const { return LayoutSize(); }

LayoutUnit intrinsicLogicalWidth() const { return style()->isHorizontalWritingMode() ? intrinsicSize().width() : intrinsicSize().height(); }

@@ -905,6 +902,7 @@ private:

// Returns true if we queued up a paint invalidation.

bool invalidatePaintOfLayerRectsForImage(WrappedImagePtr, const FillLayer&, bool drawingBackground);

+ bool stretchesToViewportInQuirksMode() const;

bool skipContainingBlockForPercentHeightCalculation(const LayoutBox* containingBlock) const;

LayoutUnit containingBlockLogicalWidthForPositioned(const LayoutBoxModelObject* containingBlock, bool checkForPerpendicularWritingMode = true) const;