Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: site/dev/sheriffing/index.md

Issue 1461613002: Update all code site issue tracker links to point to bug.skia.org (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Initial upload Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 Tree Sheriffs Documentation 1 Tree Sheriffs Documentation
2 =========================== 2 ===========================
3 3
4 ### Contents ### 4 ### Contents ###
5 5
6 * [What does a sheriff do?](#what_is_a_sheriff) 6 * [What does a sheriff do?](#what_is_a_sheriff)
7 + [Skia tree](#skia_tree) 7 + [Skia tree](#skia_tree)
8 + [DEPS rolls](#deps_rolls) 8 + [DEPS rolls](#deps_rolls)
9 + [Gold and Perf](#gold_and_perf) 9 + [Gold and Perf](#gold_and_perf)
10 + [Documentation](#sheriff_doc) 10 + [Documentation](#sheriff_doc)
(...skipping 16 matching lines...) Expand all
27 27
28 Below is a brief summary of what the sheriff does for each task: 28 Below is a brief summary of what the sheriff does for each task:
29 29
30 <a name="skia_tree"></a> 30 <a name="skia_tree"></a>
31 ### Skia tree 31 ### Skia tree
32 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo t). 32 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo t).
33 * Start watching the [status page](https://status.skia.org) for bot breakages. 33 * Start watching the [status page](https://status.skia.org) for bot breakages.
34 * Track down people responsible for breakages and revert broken changes if there is no easy fix. 34 * Track down people responsible for breakages and revert broken changes if there is no easy fix.
35 * Close and open the [tree](http://skia-tree-status.appspot.com). 35 * Close and open the [tree](http://skia-tree-status.appspot.com).
36 * Keep the builder comments on the [status page](https://status.skia.org) up to date. 36 * Keep the builder comments on the [status page](https://status.skia.org) up to date.
37 * File or follow up with [BreakingTheBuildbots bugs](https://code.google.com/p/s kia/issues/list?q=label:BreakingTheBuildbots). See the tip on [when to file bugs ](#when_to_file_bugs). 37 * File or follow up with [BreakingTheBuildbots bugs](https://bug.skia.org/?q=lab el:BreakingTheBuildbots). See the tip on [when to file bugs](#when_to_file_bugs) .
38 38
39 <a name="deps_rolls"></a> 39 <a name="deps_rolls"></a>
40 ### DEPS rolls 40 ### DEPS rolls
41 * Ensure that [AutoRoll Bot](https://skia-tree-status.appspot.com/set_arb_action )'s DEPS rolls land successfully. 41 * Ensure that [AutoRoll Bot](https://skia-tree-status.appspot.com/set_arb_action )'s DEPS rolls land successfully.
42 42
43 <a name="gold_and_perf"></a> 43 <a name="gold_and_perf"></a>
44 ### Gold and Perf 44 ### Gold and Perf
45 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s kia.org/) alerts (by clicking on the bell at the top right of the [status page]( https://status.skia.org)). 45 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s kia.org/) alerts (by clicking on the bell at the top right of the [status page]( https://status.skia.org)).
46 * The sheriff's duty here is to make sure that when developers introduce new ima ges or new perf regressions, that they are aware of what happened, and they use these tools to take appropriate action. 46 * The sheriff's duty here is to make sure that when developers introduce new ima ges or new perf regressions, that they are aware of what happened, and they use these tools to take appropriate action.
47 47
(...skipping 20 matching lines...) Expand all
68 68
69 69
70 <a name="tips"></a> 70 <a name="tips"></a>
71 Tips for sheriffs 71 Tips for sheriffs
72 ----------------- 72 -----------------
73 73
74 <a name="when_to_file_bugs"></a> 74 <a name="when_to_file_bugs"></a>
75 ### When to file bugs 75 ### When to file bugs
76 76
77 Pay close attention to the "Failures" view in the [status page](https://status.s kia.org). 77 Pay close attention to the "Failures" view in the [status page](https://status.s kia.org).
78 Look at all existing [BreakingTheBuildbots bugs](https://code.google.com/p/skia/ issues/list?q=label:BreakingTheBuildbots). If the list is kept up to date then i t should accurately represent everything that is causing failures. If it does no t, then please file/update bugs accordingly. 78 Look at all existing [BreakingTheBuildbots bugs](https://bug.skia.org/?q=label:B reakingTheBuildbots). If the list is kept up to date then it should accurately r epresent everything that is causing failures. If it does not, then please file/u pdate bugs accordingly.
79 79
80 80
81 <a name="how_close_tree"></a> 81 <a name="how_close_tree"></a>
82 ### How to close or re-open the tree 82 ### How to close or re-open the tree
83 83
84 1. Go to [skia-tree-status.appspot.com](skia-tree-status.appspot.com). 84 1. Go to [skia-tree-status.appspot.com](skia-tree-status.appspot.com).
85 2. Change the status. 85 2. Change the status.
86 * To close the tree, include the word "closed" in the status. 86 * To close the tree, include the word "closed" in the status.
87 * To open the tree, include the word "open" in the status. 87 * To open the tree, include the word "open" in the status.
88 * To caution the tree, include the word "caution" in the status. 88 * To caution the tree, include the word "caution" in the status.
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 * Add # comment about what has changed 152 * Add # comment about what has changed
153 * Add line(s) like the following after the comment: 153 * Add line(s) like the following after the comment:
154 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline ] 154 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline ]
155 * (if you took the second option above you can just edit the existing li ne(s)) 155 * (if you took the second option above you can just edit the existing li ne(s))
156 156
157 * If you took the first/dispreferred option above: 157 * If you took the first/dispreferred option above:
158 * Wait for the Blink patch to roll into Chrome 158 * Wait for the Blink patch to roll into Chrome
159 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp ectations.txt 159 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp ectations.txt
160 160
161 161
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698