Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1461603002: [turbofan] Ship TurboFan with spread expressions. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_fix-osr-in-literal-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship TurboFan with spread expressions. This triggers TurboFan whenever functions containing spread expressions of any kind are marked for optimization. Note that this increases the set of functions being eligible for optimization. R=rossberg@chromium.org,hablich@chromium.org Committed: https://crrev.com/e90a0b3cef83e06cc5d95f8660a368cd59cc8deb Cr-Commit-Position: refs/heads/master@{#32083}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-18 10:54:54 UTC) #1
Benedikt Meurer
LGTM, nice!
5 years, 1 month ago (2015-11-18 11:35:37 UTC) #3
Michael Hablich
On 2015/11/18 11:35:37, Benedikt Meurer wrote: > LGTM, nice! lgtm
5 years, 1 month ago (2015-11-18 11:38:16 UTC) #4
rossberg
lgtm
5 years, 1 month ago (2015-11-18 12:00:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461603002/20001
5 years, 1 month ago (2015-11-18 12:04:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 13:51:49 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 13:52:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e90a0b3cef83e06cc5d95f8660a368cd59cc8deb
Cr-Commit-Position: refs/heads/master@{#32083}

Powered by Google App Engine
This is Rietveld 408576698