Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 14615010: [Sync] Add interface and backend impl for typed URL syncable service (Closed)

Created:
7 years, 7 months ago by Nicolas Zea
Modified:
7 years, 7 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

[Sync] Add interface and backend impl for typed URL syncable service The typed URL sync datatype is being transitioned to the syncable service API, and this patch introduces the new interface the typed url sync code will use to communicate with sync as well as the HistoryBackend which implements the datatype. This patch implements logic for syncing typed url changes originating from the history backend to the sync server, through the syncable service API. Original patch by mgist1@chromium.org. Review at https://codereview.chromium.org/12703036/ BUG=77819 TBR=brettw@chromium.org, atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198789

Patch Set 1 #

Patch Set 2 : Address Brett's final comments #

Patch Set 3 : Fix android compile #

Patch Set 4 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1327 lines, -1 line) Patch
M chrome/browser/history/expire_history_backend.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/history_backend.h View 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 8 chunks +23 lines, -1 line 0 comments Download
M chrome/browser/history/history_service.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/browser/history/typed_url_syncable_service.h View 1 chunk +164 lines, -0 lines 0 comments Download
A chrome/browser/history/typed_url_syncable_service.cc View 1 1 chunk +444 lines, -0 lines 0 comments Download
A chrome/browser/history/typed_url_syncable_service_unittest.cc View 1 2 3 1 chunk +657 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nicolas Zea
+TBR Drew and Brett. This just rebases addresses the final nits from Brett. Landing via ...
7 years, 7 months ago (2013-05-06 19:23:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/14615010/14
7 years, 7 months ago (2013-05-06 19:24:19 UTC) #2
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-06 19:58:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/14615010/16001
7 years, 7 months ago (2013-05-06 20:59:48 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-06 21:49:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/14615010/30001
7 years, 7 months ago (2013-05-06 21:54:01 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=124580
7 years, 7 months ago (2013-05-06 23:04:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/14615010/30001
7 years, 7 months ago (2013-05-07 17:20:37 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125032
7 years, 7 months ago (2013-05-07 17:56:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/14615010/30001
7 years, 7 months ago (2013-05-07 20:01:04 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125217
7 years, 7 months ago (2013-05-07 20:28:42 UTC) #11
Nicolas Zea
7 years, 7 months ago (2013-05-07 20:35:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 manually as r198789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698