Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: third_party/WebKit/Source/core/page/AutoscrollController.cpp

Issue 1461473002: Ensure that the auto scroll state in the AutoscrollController is cleared if the scroll operation cl… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another attempt to fix layout test redness Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/resources/iframe-with-overflow-scrollable-div.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 124
125 #if OS(WIN) 125 #if OS(WIN)
126 HitTestResult hitTest = layoutObject->frame()->eventHandler().hitTestResultA tPoint(m_panScrollStartPos, HitTestRequest::ReadOnly | HitTestRequest::Active); 126 HitTestResult hitTest = layoutObject->frame()->eventHandler().hitTestResultA tPoint(m_panScrollStartPos, HitTestRequest::ReadOnly | HitTestRequest::Active);
127 127
128 if (Node* nodeAtPoint = hitTest.innerNode()) 128 if (Node* nodeAtPoint = hitTest.innerNode())
129 layoutObject = nodeAtPoint->layoutObject(); 129 layoutObject = nodeAtPoint->layoutObject();
130 #endif 130 #endif
131 131
132 while (layoutObject && !(layoutObject->isBox() && toLayoutBox(layoutObject)- >canAutoscroll())) 132 while (layoutObject && !(layoutObject->isBox() && toLayoutBox(layoutObject)- >canAutoscroll()))
133 layoutObject = layoutObject->parent(); 133 layoutObject = layoutObject->parent();
134 m_autoscrollLayoutObject = layoutObject && layoutObject->isBox() ? toLayoutB ox(layoutObject) : nullptr; 134
135 LayoutBox* autoscrollLayoutObject = layoutObject && layoutObject->isBox() ? toLayoutBox(layoutObject) : nullptr;
136 if (m_autoscrollLayoutObject && !autoscrollLayoutObject)
137 stopAutoscrollIfNeeded(m_autoscrollLayoutObject);
138
139 m_autoscrollLayoutObject = autoscrollLayoutObject;
135 } 140 }
136 141
137 void AutoscrollController::updateDragAndDrop(Node* dropTargetNode, const IntPoin t& eventPosition, double eventTime) 142 void AutoscrollController::updateDragAndDrop(Node* dropTargetNode, const IntPoin t& eventPosition, double eventTime)
138 { 143 {
139 if (!dropTargetNode || !dropTargetNode->layoutObject()) { 144 if (!dropTargetNode || !dropTargetNode->layoutObject()) {
140 stopAutoscroll(); 145 stopAutoscroll();
141 return; 146 return;
142 } 147 }
143 148
144 if (m_autoscrollLayoutObject && m_autoscrollLayoutObject->frame() != dropTar getNode->layoutObject()->frame()) 149 if (m_autoscrollLayoutObject && m_autoscrollLayoutObject->frame() != dropTar getNode->layoutObject()->frame())
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 view->setCursor(eastPanningCursor()); 303 view->setCursor(eastPanningCursor());
299 } else if (west) { 304 } else if (west) {
300 view->setCursor(westPanningCursor()); 305 view->setCursor(westPanningCursor());
301 } else { 306 } else {
302 view->setCursor(middlePanningCursor()); 307 view->setCursor(middlePanningCursor());
303 } 308 }
304 } 309 }
305 #endif 310 #endif
306 311
307 } // namespace blink 312 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/resources/iframe-with-overflow-scrollable-div.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698