Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/browser/thumbnails/thumbnailing_context.h

Issue 1461463002: Reland fix for thumbnail generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_THUMBNAILS_THUMBNAILING_CONTEXT_H_ 5 #ifndef CHROME_BROWSER_THUMBNAILS_THUMBNAILING_CONTEXT_H_
6 #define CHROME_BROWSER_THUMBNAILS_THUMBNAILING_CONTEXT_H_ 6 #define CHROME_BROWSER_THUMBNAILS_THUMBNAILING_CONTEXT_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "chrome/browser/thumbnails/thumbnail_service.h" 10 #include "chrome/browser/thumbnails/thumbnail_service.h"
11 #include "components/history/core/common/thumbnail_score.h" 11 #include "components/history/core/common/thumbnail_score.h"
12 #include "content/public/browser/web_contents.h" 12 #include "content/public/browser/web_contents.h"
13 #include "content/public/browser/web_contents_observer.h"
13 #include "ui/gfx/geometry/size.h" 14 #include "ui/gfx/geometry/size.h"
14 15
15 namespace thumbnails { 16 namespace thumbnails {
16 17
17 // The result of clipping. This can be used to determine if the 18 // The result of clipping. This can be used to determine if the
18 // generated thumbnail is good or not. 19 // generated thumbnail is good or not.
19 enum ClipResult { 20 enum ClipResult {
20 // Clipping is not done yet. 21 // Clipping is not done yet.
21 CLIP_RESULT_UNPROCESSED, 22 CLIP_RESULT_UNPROCESSED,
22 // The source image is smaller. 23 // The source image is smaller.
23 CLIP_RESULT_SOURCE_IS_SMALLER, 24 CLIP_RESULT_SOURCE_IS_SMALLER,
24 // Wider than tall by twice or more, clip horizontally. 25 // Wider than tall by twice or more, clip horizontally.
25 CLIP_RESULT_MUCH_WIDER_THAN_TALL, 26 CLIP_RESULT_MUCH_WIDER_THAN_TALL,
26 // Wider than tall, clip horizontally. 27 // Wider than tall, clip horizontally.
27 CLIP_RESULT_WIDER_THAN_TALL, 28 CLIP_RESULT_WIDER_THAN_TALL,
28 // Taller than wide, clip vertically. 29 // Taller than wide, clip vertically.
29 CLIP_RESULT_TALLER_THAN_WIDE, 30 CLIP_RESULT_TALLER_THAN_WIDE,
30 // The source and destination aspect ratios are identical. 31 // The source and destination aspect ratios are identical.
31 CLIP_RESULT_NOT_CLIPPED, 32 CLIP_RESULT_NOT_CLIPPED,
32 // The source and destination are identical. 33 // The source and destination are identical.
33 CLIP_RESULT_SOURCE_SAME_AS_TARGET, 34 CLIP_RESULT_SOURCE_SAME_AS_TARGET,
34 }; 35 };
35 36
36 // Holds the information needed for processing a thumbnail. 37 // Holds the information needed for processing a thumbnail.
37 struct ThumbnailingContext : base::RefCountedThreadSafe<ThumbnailingContext> { 38 class ThumbnailingContext
39 : public base::RefCountedThreadSafe<ThumbnailingContext>,
40 public content::WebContentsObserver {
41 public:
38 ThumbnailingContext(content::WebContents* web_contents, 42 ThumbnailingContext(content::WebContents* web_contents,
39 ThumbnailService* receiving_service, 43 ThumbnailService* receiving_service,
40 bool load_interrupted); 44 bool load_interrupted);
41 45
42 // Create an instance for use with unit tests. 46 // Create an instance for use with unit tests.
43 static ThumbnailingContext* CreateThumbnailingContextForTest() { 47 static ThumbnailingContext* CreateThumbnailingContextForTest() {
44 return new ThumbnailingContext(); 48 return new ThumbnailingContext();
45 } 49 }
46 50
47 scoped_refptr<ThumbnailService> service; 51 const scoped_refptr<ThumbnailService>& service() const;
48 GURL url; 52
49 ClipResult clip_result; 53 const GURL& GetURL() const;
50 gfx::Size requested_copy_size; 54
51 ThumbnailScore score; 55 ClipResult clip_result() const;
56 void set_clip_result(ClipResult result);
57
58 gfx::Size requested_copy_size();
59 void set_requested_copy_size(const gfx::Size& requested_size);
60
61 ThumbnailScore score() const;
62 void SetBoringScore(double score);
63 void SetGoodClipping(bool is_good_clipping);
52 64
53 private: 65 private:
54 ThumbnailingContext(); 66 ThumbnailingContext();
55 ~ThumbnailingContext(); 67 ~ThumbnailingContext() override;
56 68
57 friend class base::RefCountedThreadSafe<ThumbnailingContext>; 69 friend class base::RefCountedThreadSafe<ThumbnailingContext>;
70
71 scoped_refptr<ThumbnailService> service_;
72 ClipResult clip_result_;
73 gfx::Size requested_copy_size_;
74 ThumbnailScore score_;
58 }; 75 };
59 76
60 } // namespace thumbnails 77 } // namespace thumbnails
61 78
62 #endif // CHROME_BROWSER_THUMBNAILS_THUMBNAILING_CONTEXT_H_ 79 #endif // CHROME_BROWSER_THUMBNAILS_THUMBNAILING_CONTEXT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698