Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1461453002: Flip 'Linux x64' bot on chromium waterfall to GN. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip 'Linux x64' bot on chromium waterfall to GN. This flips the Linux x64 bot on the chromium waterfall to GN, and cleans up some mistakes in the MB config (the builders should've been setting linux_dump_symbols=0, which is the default, not linux_dump_symbols=1). TBR=phajdan.jr@chromium.org, brettw@chromium.org BUG=530733, 432959 Committed: https://crrev.com/9bb757129af95f0ca1539c65269cd8bc85df04f8 Cr-Commit-Position: refs/heads/master@{#360510}

Patch Set 1 #

Patch Set 2 : flip tryserver over also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M remoting/host/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 5 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461453002/1
5 years, 1 month ago (2015-11-18 01:18:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461453002/20001
5 years, 1 month ago (2015-11-19 00:34:40 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-19 00:34:41 UTC) #7
Dirk Pranke
5 years, 1 month ago (2015-11-19 00:53:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461453002/20001
5 years, 1 month ago (2015-11-19 00:55:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 03:12:34 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9bb757129af95f0ca1539c65269cd8bc85df04f8 Cr-Commit-Position: refs/heads/master@{#360510}
5 years, 1 month ago (2015-11-19 03:13:28 UTC) #14
Dirk Pranke
5 years, 1 month ago (2015-11-19 08:48:41 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1457593005/ by dpranke@chromium.org.

The reason for reverting is: compiling 'all' fails w/ GN:

http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/12149/steps/....

Powered by Google App Engine
This is Rietveld 408576698