Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1461423002: Revert of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo. (Closed)

Created:
5 years, 1 month ago by David Yen
Modified:
5 years, 1 month ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo. (patchset #10 id:200001 of https://codereview.chromium.org/1419913002/ ) Reason for revert: Looks to be causing bot failures for ContextLost.WebGLContextLostInHiddenTab Original issue's description: > Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo. > > It is now legal for Blink to provide an implementation of cc::LayerClient. > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/69698f992d3c6b2badd01f718c71df7a52b099fb > Cr-Commit-Position: refs/heads/master@{#360855} TBR=chrishtr@chromium.org,danakj@chromium.org,enne@chromium.org,esprehn@chromium.org,pdr@chromium.org,jbroman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d32d4303200f2d9d016f8428546f3b30978726f3 Cr-Commit-Position: refs/heads/master@{#360892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -118 lines) Patch
M cc/blink/web_layer_impl.h View 3 chunks +8 lines, -3 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 3 chunks +40 lines, -6 lines 0 comments Download
M cc/layers/layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_client.h View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 9 chunks +15 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerDebugInfo.h View 2 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerDebugInfo.cpp View 2 chunks +48 lines, -28 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebGraphicsLayerDebugInfo.h View 1 chunk +50 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 2 chunks +2 lines, -10 lines 0 comments Download
A third_party/WebKit/public/platform/WebLayerClient.h View 1 chunk +55 lines, -0 lines 0 comments Download
M ui/compositor/layer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
David Yen
Created Revert of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo.
5 years, 1 month ago (2015-11-20 19:51:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461423002/1
5 years, 1 month ago (2015-11-20 19:53:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 19:55:18 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 19:56:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d32d4303200f2d9d016f8428546f3b30978726f3
Cr-Commit-Position: refs/heads/master@{#360892}

Powered by Google App Engine
This is Rietveld 408576698