Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1461413004: Ignore title changes from WKWebView when the web process dies (Closed)

Created:
5 years, 1 month ago by stuartmorgan
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore title changes from WKWebView when the web process dies WKWebView sets the title to blank when the web process dies; ignore that update so that the navigation item won't end up with a blank title. BUG=558178 Committed: https://crrev.com/8915d5073ac9a5f3e5116f1cb1d496afb7293518 Cr-Commit-Position: refs/heads/master@{#361214}

Patch Set 1 #

Total comments: 2

Patch Set 2 : DCHECK_EQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 1 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
stuartmorgan
5 years, 1 month ago (2015-11-20 23:22:59 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/1461413004/diff/1/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm File ios/web/web_state/ui/crw_wk_web_view_web_controller.mm (right): https://codereview.chromium.org/1461413004/diff/1/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm#newcode1488 ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:1488: DCHECK(self.title.length == 0); Optional NIT: DCHECK_EQ
5 years, 1 month ago (2015-11-20 23:24:40 UTC) #3
stuartmorgan
https://codereview.chromium.org/1461413004/diff/1/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm File ios/web/web_state/ui/crw_wk_web_view_web_controller.mm (right): https://codereview.chromium.org/1461413004/diff/1/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm#newcode1488 ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:1488: DCHECK(self.title.length == 0); On 2015/11/20 23:24:40, eugenebut wrote: > ...
5 years, 1 month ago (2015-11-23 22:45:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461413004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461413004/20001
5 years, 1 month ago (2015-11-23 22:46:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 23:19:48 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 23:20:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8915d5073ac9a5f3e5116f1cb1d496afb7293518
Cr-Commit-Position: refs/heads/master@{#361214}

Powered by Google App Engine
This is Rietveld 408576698