Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1461403003: [DevTools] Call directly into underlying http transaction when throttling is disabled. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Call directly into underlying http transaction when throttling is disabled. This guarantees that any throttling-specific errors do no affect no-throttling scenario. BUG=none Committed: https://crrev.com/881ef3f3d4e0738c30af2ef47a728dba5dfa94a0 Cr-Commit-Position: refs/heads/master@{#361193}

Patch Set 1 #

Patch Set 2 : wrong order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/devtools/devtools_network_transaction.cc View 1 6 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgozman
Take a look please.
5 years, 1 month ago (2015-11-20 22:13:09 UTC) #2
pfeldman
lgtm
5 years, 1 month ago (2015-11-20 22:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461403003/1
5 years, 1 month ago (2015-11-20 22:45:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/132214) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 23:19:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461403003/20001
5 years, 1 month ago (2015-11-23 20:22:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 21:49:58 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 21:50:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/881ef3f3d4e0738c30af2ef47a728dba5dfa94a0
Cr-Commit-Position: refs/heads/master@{#361193}

Powered by Google App Engine
This is Rietveld 408576698