Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: Source/core/platform/ScrollView.cpp

Issue 14614007: Remove frame flattening from rendering code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: better. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/platform/ScrollView.h ('k') | Source/core/rendering/RenderFrameBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/platform/ScrollView.cpp
diff --git a/Source/core/platform/ScrollView.cpp b/Source/core/platform/ScrollView.cpp
index 5a06473b98710bbf126a9a9b19d0f741f6817795..602132cd673f05c8ead4fbb03a820368aa3e7c7d 100644
--- a/Source/core/platform/ScrollView.cpp
+++ b/Source/core/platform/ScrollView.cpp
@@ -82,7 +82,6 @@ void ScrollView::removeChild(Widget* child)
void ScrollView::setHasHorizontalScrollbar(bool hasBar)
{
- ASSERT(!hasBar || !avoidScrollbarCreation());
if (hasBar && !m_horizontalScrollbar) {
m_horizontalScrollbar = createScrollbar(HorizontalScrollbar);
addChild(m_horizontalScrollbar.get());
@@ -100,7 +99,6 @@ void ScrollView::setHasHorizontalScrollbar(bool hasBar)
void ScrollView::setHasVerticalScrollbar(bool hasBar)
{
- ASSERT(!hasBar || !avoidScrollbarCreation());
if (hasBar && !m_verticalScrollbar) {
m_verticalScrollbar = createScrollbar(VerticalScrollbar);
addChild(m_verticalScrollbar.get());
@@ -408,9 +406,9 @@ void ScrollView::updateScrollbars(const IntSize& desiredOffset)
newHasVerticalScrollbar = (vScroll == ScrollbarAlwaysOn);
if (m_scrollbarsSuppressed || (hScroll != ScrollbarAuto && vScroll != ScrollbarAuto)) {
- if (hasHorizontalScrollbar != newHasHorizontalScrollbar && (hasHorizontalScrollbar || !avoidScrollbarCreation()))
+ if (hasHorizontalScrollbar != newHasHorizontalScrollbar)
setHasHorizontalScrollbar(newHasHorizontalScrollbar);
- if (hasVerticalScrollbar != newHasVerticalScrollbar && (hasVerticalScrollbar || !avoidScrollbarCreation()))
+ if (hasVerticalScrollbar != newHasVerticalScrollbar)
setHasVerticalScrollbar(newHasVerticalScrollbar);
} else {
bool scrollbarExistenceChanged = false;
@@ -441,7 +439,7 @@ void ScrollView::updateScrollbars(const IntSize& desiredOffset)
}
bool scrollbarIsOverlay = ScrollbarTheme::theme()->usesOverlayScrollbars();
- if (hasHorizontalScrollbar != newHasHorizontalScrollbar && (hasHorizontalScrollbar || !avoidScrollbarCreation())) {
+ if (hasHorizontalScrollbar != newHasHorizontalScrollbar) {
scrollbarExistenceChanged = true;
if (scrollOrigin().y() && !newHasHorizontalScrollbar && !scrollbarsAreOverlay)
ScrollableArea::setScrollOrigin(IntPoint(scrollOrigin().x(), scrollOrigin().y() - m_horizontalScrollbar->height()));
@@ -450,7 +448,7 @@ void ScrollView::updateScrollbars(const IntSize& desiredOffset)
setHasHorizontalScrollbar(newHasHorizontalScrollbar);
}
- if (hasVerticalScrollbar != newHasVerticalScrollbar && (hasVerticalScrollbar || !avoidScrollbarCreation())) {
+ if (hasVerticalScrollbar != newHasVerticalScrollbar) {
scrollbarExistenceChanged = true;
if (scrollOrigin().x() && !newHasVerticalScrollbar && !scrollbarsAreOverlay)
ScrollableArea::setScrollOrigin(IntPoint(scrollOrigin().x() - m_verticalScrollbar->width(), scrollOrigin().y()));
« no previous file with comments | « Source/core/platform/ScrollView.h ('k') | Source/core/rendering/RenderFrameBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698