Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 14614007: Remove frame flattening from rendering code. (Closed)

Created:
7 years, 7 months ago by Mike West
Modified:
7 years, 7 months ago
CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Remove frame flattening from rendering code. Chromium never enables frame flattening; we can simplify frame rendering by removing the various paths that only execute if flattening is enabled. Currently, this patch leaves RenderFrameBase as an empty shell. We will remove that entirely in a subsequent patch. This is a reland of a reland of a reland. It's totally going to work this time. Carrying over Ojan's LGTM from the original patch: https://codereview.chromium.org/13877010 BUG=231902 TBR=ojan Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150495

Patch Set 1 #

Patch Set 2 : Got it. #

Total comments: 1

Patch Set 3 : better. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -411 lines) Patch
D LayoutTests/fast/spatial-navigation/snav-iframe-flattening-simple.html View 1 1 chunk +0 lines, -74 lines 0 comments Download
D LayoutTests/fast/spatial-navigation/snav-iframe-flattening-simple-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameView.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/page/FrameView.cpp View 1 2 10 chunks +11 lines, -83 lines 0 comments Download
M Source/core/page/Settings.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/ScrollView.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/ScrollView.cpp View 1 5 chunks +4 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderFrameBase.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderFrameBase.cpp View 1 chunk +3 lines, -65 lines 0 comments Download
M Source/core/rendering/RenderFrameSet.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 3 chunks +1 line, -120 lines 0 comments Download
M Source/core/rendering/RenderIFrame.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderIFrame.cpp View 2 chunks +0 lines, -32 lines 0 comments Download
M Source/core/rendering/TextAutosizer.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike West
https://codereview.chromium.org/14614007/diff/3001/Source/core/page/FrameView.cpp File Source/core/page/FrameView.cpp (right): https://codereview.chromium.org/14614007/diff/3001/Source/core/page/FrameView.cpp#newcode916 Source/core/page/FrameView.cpp:916: if (!m_nestedLayoutCount && !m_inSynchronousPostLayout && m_postLayoutTasksTimer.isActive() && !frame()->document()->shouldDisplaySeamlesslyWithParent()) { ...
7 years, 7 months ago (2013-05-14 08:33:03 UTC) #1
kenneth.christiansen
lgtm, let's hope this passes!
7 years, 7 months ago (2013-05-14 08:37:30 UTC) #2
Mike West
Jochen, would you mind taking a look at the single Source/WebKit change?
7 years, 7 months ago (2013-05-14 10:51:12 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 7 months ago (2013-05-14 11:01:06 UTC) #4
Mike West
*sigh* It would be nice if the trybots were at all helpful. :/
7 years, 7 months ago (2013-05-14 11:44:22 UTC) #5
Mike West
On 2013/05/14 11:44:22, Mike West (chromium) wrote: > *sigh* It would be nice if the ...
7 years, 7 months ago (2013-05-16 07:48:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/14614007/15001
7 years, 7 months ago (2013-05-16 07:50:13 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 08:16:37 UTC) #8
Message was sent while issue was closed.
Change committed as 150495

Powered by Google App Engine
This is Rietveld 408576698