Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 146136: Add a command line switch to allow setting the max size... (Closed)

Created:
11 years, 6 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium, Ben Goodger (Google)
Visibility:
Public.

Description

Add a command line switch to allow setting the max size of the disk cache. This switch is intended for troubleshooting, not to add another supported configuration. BUG=15117 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19439

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -28 lines) Patch
M chrome/browser/net/chrome_url_request_context.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 5 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/profile.cc View 1 3 chunks +46 lines, -18 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rvargas (doing something else)
11 years, 6 months ago (2009-06-25 03:41:14 UTC) #1
cpu_(ooo_6.6-7.5)
The change looks good. I have two comments: http://codereview.chromium.org/146136/diff/1/5 File chrome/browser/net/chrome_url_request_context.h (right): http://codereview.chromium.org/146136/diff/1/5#newcode33 Line 33: ...
11 years, 6 months ago (2009-06-25 19:41:56 UTC) #2
rvargas (doing something else)
Thanks. Please take another look.
11 years, 6 months ago (2009-06-26 04:01:44 UTC) #3
cpu_(ooo_6.6-7.5)
11 years, 6 months ago (2009-06-26 18:10:36 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698