Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1461343002: Make AssistContributor asynchronous. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+694 lines, -535 lines) Patch
M pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart View 2 chunks +31 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart View 1 chunk +51 lines, -16 lines 2 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 2 chunks +31 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 5 chunks +28 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 3 chunks +42 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 6 chunks +10 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 233 chunks +494 lines, -476 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-20 17:47:49 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1461343002/diff/1/pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart File pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart (right): https://codereview.chromium.org/1461343002/diff/1/pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart#newcode19 pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart:19: class DartAssistContext { It would be better for ...
5 years, 1 month ago (2015-11-20 19:10:11 UTC) #2
scheglov
5 years, 1 month ago (2015-11-20 20:18:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ae1bee3859ad7a98826508f00cc04eaf2b3d2640 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698