Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 1461313004: Make FixContributor asynchronous. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweaks Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/edit/edit_domain.dart
diff --git a/pkg/analysis_server/lib/src/edit/edit_domain.dart b/pkg/analysis_server/lib/src/edit/edit_domain.dart
index 6b11d2d276ce8ed980e67ed2cc530d53d287113f..18651466477f61ee763508069ea86ee63fd312eb 100644
--- a/pkg/analysis_server/lib/src/edit/edit_domain.dart
+++ b/pkg/analysis_server/lib/src/edit/edit_domain.dart
@@ -148,7 +148,7 @@ class EditDomainHandler implements RequestHandler {
server.sendResponse(response);
}
- Response getFixes(Request request) {
+ getFixes(Request request) async {
var params = new EditGetFixesParams.fromRequest(request);
String file = params.file;
int offset = params.offset;
@@ -163,7 +163,7 @@ class EditDomainHandler implements RequestHandler {
for (engine.AnalysisError error in errorInfo.errors) {
int errorLine = lineInfo.getLocation(error.offset).lineNumber;
if (errorLine == requestLine) {
- List<Fix> fixes = computeFixes(server.serverPlugin,
+ List<Fix> fixes = await computeFixes(server.serverPlugin,
server.resourceProvider, unit.element.context, error);
if (fixes.isNotEmpty) {
AnalysisError serverError =
@@ -180,7 +180,8 @@ class EditDomainHandler implements RequestHandler {
}
}
// respond
- return new EditGetFixesResult(errorFixesList).toResponse(request.id);
+ return server.sendResponse(
+ new EditGetFixesResult(errorFixesList).toResponse(request.id));
}
@override
@@ -195,7 +196,8 @@ class EditDomainHandler implements RequestHandler {
} else if (requestName == EDIT_GET_AVAILABLE_REFACTORINGS) {
return _getAvailableRefactorings(request);
} else if (requestName == EDIT_GET_FIXES) {
- return getFixes(request);
+ getFixes(request);
+ return Response.DELAYED_RESPONSE;
} else if (requestName == EDIT_GET_REFACTORING) {
return _getRefactoring(request);
} else if (requestName == EDIT_ORGANIZE_DIRECTIVES) {
« no previous file with comments | « pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart ('k') | pkg/analysis_server/lib/src/services/correction/fix.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698