Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 14613002: Tests for invalid suggestions (i.e. expired cards) in the Autofill dialog. (Closed)

Created:
7 years, 7 months ago by Dan Beam
Modified:
7 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Tests for invalid suggestions (i.e. expired cards) in the Autofill dialog. Related to https://codereview.chromium.org/14425010/ R=estade@chromium.org BUG=168680 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203347

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 2 3 chunks +41 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dan Beam
7 years, 6 months ago (2013-05-30 01:24:55 UTC) #1
Evan Stade
lgtm!
7 years, 6 months ago (2013-05-31 00:03:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/14613002/10001
7 years, 6 months ago (2013-05-31 01:49:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=156156
7 years, 6 months ago (2013-05-31 05:19:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/14613002/10001
7 years, 6 months ago (2013-05-31 07:03:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/14613002/10001
7 years, 6 months ago (2013-05-31 07:04:27 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 07:05:53 UTC) #7
Message was sent while issue was closed.
Change committed as 203347

Powered by Google App Engine
This is Rietveld 408576698