Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1461283004: DevTools: defer reveal in TreeOutline using rAF (Closed)

Created:
5 years, 1 month ago by caseq
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: defer reveal in TreeOutline using rAF - only do scrollIntoViewIfNeeded() in a rAF callback to avoid forcing layout; - get rid of TreeElement.onreveal() as most implementation were a no-op just repeating what the call site has already done; - added `center' parameter to TreeElement.reveal() - do not center when scrolling with keyboard or searching; BUG= Committed: https://crrev.com/a5f7c0a3696886422abc479b6da79c1b7dc1fbda Cr-Commit-Position: refs/heads/master@{#361209}

Patch Set 1 #

Messages

Total messages: 15 (6 generated)
caseq
5 years, 1 month ago (2015-11-21 02:01:50 UTC) #2
pfeldman
lgtm
5 years, 1 month ago (2015-11-21 02:04:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461283004/1
5 years, 1 month ago (2015-11-21 02:08:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/138480)
5 years, 1 month ago (2015-11-21 03:58:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461283004/1
5 years, 1 month ago (2015-11-23 19:06:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/132964)
5 years, 1 month ago (2015-11-23 20:41:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461283004/1
5 years, 1 month ago (2015-11-23 21:39:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 23:09:03 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 23:10:05 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5f7c0a3696886422abc479b6da79c1b7dc1fbda
Cr-Commit-Position: refs/heads/master@{#361209}

Powered by Google App Engine
This is Rietveld 408576698