Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1461273003: Remove already obsolete CREDENTIAL frame from SPDY code. (Closed)

Created:
5 years, 1 month ago by Bence
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove already obsolete CREDENTIAL frame from SPDY code. Support for CREDENTIAL frames was removed long ago (when SPDY/3 support was removed). This CL cleans up remaining unused data members, methods, enum values, constants, tests, and comments. Functionality change: incoming CREDENTIAL frames used to be ignored, now they cause an error. BUG=311852 Committed: https://crrev.com/99fbe5b572d435466e380334a947401ed15d11d8 Cr-Commit-Position: refs/heads/master@{#360974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -118 lines) Patch
M net/quic/quic_headers_stream_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_framer.cc View 6 chunks +3 lines, -20 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 2 chunks +0 lines, -68 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_protocol.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_session.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 1 month ago (2015-11-20 15:35:22 UTC) #2
Ryan Hamilton
lgtm
5 years, 1 month ago (2015-11-20 23:30:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461273003/1
5 years, 1 month ago (2015-11-21 00:49:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 01:07:50 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 01:09:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99fbe5b572d435466e380334a947401ed15d11d8
Cr-Commit-Position: refs/heads/master@{#360974}

Powered by Google App Engine
This is Rietveld 408576698