content/common/render_widget_view.mojom - Issue 1461243002: [OLD ATTEMPT, DO NOT REVIEW] mustash: Enable connections to mus from the Chrome renderer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/render_widget_view.mojom

Issue 1461243002: [OLD ATTEMPT, DO NOT REVIEW] mustash: Enable connections to mus from the Chrome renderer Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: A bunch of cleanup Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/common/mojo/mojo_shell_connection_impl.cc ('K') | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | content/public/browser/BUILD.gn » ('j') | content/renderer/render_view_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module content.mojom;

	6

	7 import "components/mus/public/interfaces/window_tree.mojom";

	8

	9 interface RenderWidgetViewFactory {
	Ben Goodger (Google) 2015/11/24 06:42:40 technically this file should be called render_widg technically this file should be called render_widget_view_factory.mojom unless you plan on adding an interface to the view itself. Fady Samuel 2015/11/24 13:32:06 Renamed to RenderProcessClient and render_process_ Show quoted text On 2015/11/24 06:42:40, Ben Goodger (Google) wrote: > technically this file should be called render_widget_view_factory.mojom unless > you plan on adding an interface to the view itself. Renamed to RenderProcessClient and render_process_client.mojom. This seems to be better fit to what this thing is, sorta.
	10 CreateRenderWidgetView(uint32 routing_id,
	Ben Goodger (Google) 2015/11/24 06:42:40 I'd call this RenderWidgetViewCreated. You're not I'd call this RenderWidgetViewCreated. You're not creating a new object in the browser, merely notifying it that one was constructed in the renderer. Fady Samuel 2015/11/24 13:32:06 Done. Show quoted text On 2015/11/24 06:42:40, Ben Goodger (Google) wrote: > I'd call this RenderWidgetViewCreated. You're not creating a new object in the > browser, merely notifying it that one was constructed in the renderer. Done.
	11 mus.mojom.WindowTreeClient window_tree_client);

	12 };

OLD	NEW