Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 14612012: Cleaned up deopt output a bit. (Closed)

Created:
7 years, 7 months ago by Sven Panne
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Cleaned up deopt output a bit. Be a bit more consistent it what is printed. Removed the now superfluous "*** DEOPT"-like output. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14702

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added grep marker. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -37 lines) Patch
M src/arm/deoptimizer-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 1 5 chunks +16 lines, -28 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sven Panne
7 years, 7 months ago (2013-05-16 08:14:20 UTC) #1
Jakob Kummerow
small DBC. https://codereview.chromium.org/14612012/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/14612012/diff/1/src/deoptimizer.cc#newcode709 src/deoptimizer.cc:709: PrintF("[deoptimizing (%s): begin 0x%08" V8PRIxPTR " ", ...
7 years, 7 months ago (2013-05-16 08:49:29 UTC) #2
Jakob Kummerow
small DBC. https://codereview.chromium.org/14612012/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/14612012/diff/1/src/deoptimizer.cc#newcode709 src/deoptimizer.cc:709: PrintF("[deoptimizing (%s): begin 0x%08" V8PRIxPTR " ", ...
7 years, 7 months ago (2013-05-16 08:49:29 UTC) #3
Michael Starzinger
https://codereview.chromium.org/14612012/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/14612012/diff/1/src/deoptimizer.cc#newcode709 src/deoptimizer.cc:709: PrintF("[deoptimizing (%s): begin 0x%08" V8PRIxPTR " ", On 2013/05/16 ...
7 years, 7 months ago (2013-05-16 08:53:47 UTC) #4
Michael Starzinger
LGTM if Jakob's comment is addressed.
7 years, 7 months ago (2013-05-16 09:15:17 UTC) #5
Sven Panne
7 years, 7 months ago (2013-05-16 09:45:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r14702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698