Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 14612002: [FileAPI] Disable usage cache for origin after file opening for pepper. (Closed)

Created:
7 years, 7 months ago by tzik
Modified:
7 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

[FileAPI] Disable usage cache for origin after file opening for pepper. For PERSISTENT FileSystem on UnlimitedStorage origin, a file descriptor opened by CreateOrOpen can be passed to a pepper plugin, and we'll lose report-based usage tracking. This CL conservatively disables usage cache for the origin until browser restart in the case, and invokes the usage recalculation on a usage query. BUG=220029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197312

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -74 lines) Patch
M webkit/fileapi/obfuscated_file_util.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.cc View 1 2 chunks +91 lines, -74 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTL
7 years, 7 months ago (2013-04-30 04:57:46 UTC) #1
kinuko
https://codereview.chromium.org/14612002/diff/1/webkit/fileapi/obfuscated_file_util.cc File webkit/fileapi/obfuscated_file_util.cc (right): https://codereview.chromium.org/14612002/diff/1/webkit/fileapi/obfuscated_file_util.cc#newcode268 webkit/fileapi/obfuscated_file_util.cc:268: url.type() == kFileSystemTypePersistent) { instead should we check context->quota_limit_type() ...
7 years, 7 months ago (2013-04-30 05:14:23 UTC) #2
tzik
https://codereview.chromium.org/14612002/diff/1/webkit/fileapi/obfuscated_file_util.cc File webkit/fileapi/obfuscated_file_util.cc (right): https://codereview.chromium.org/14612002/diff/1/webkit/fileapi/obfuscated_file_util.cc#newcode268 webkit/fileapi/obfuscated_file_util.cc:268: url.type() == kFileSystemTypePersistent) { On 2013/04/30 05:14:23, kinuko wrote: ...
7 years, 7 months ago (2013-04-30 05:26:22 UTC) #3
kinuko
lgtm
7 years, 7 months ago (2013-04-30 05:40:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/14612002/7001
7 years, 7 months ago (2013-04-30 05:59:07 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 08:34:52 UTC) #6
Message was sent while issue was closed.
Change committed as 197312

Powered by Google App Engine
This is Rietveld 408576698