Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1461173002: Stop using rtc::scoped_ptr::Pass() (Closed)

Created:
5 years, 1 month ago by kwiberg-chromium
Modified:
5 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using rtc::scoped_ptr::Pass() It will soon be gone, so use std::move instead---or ensure that the expression is already an rvalue. Committed: https://crrev.com/b854092fc667d594c9f31686a101067d74d7d6d7 Cr-Commit-Position: refs/heads/master@{#360794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M content/renderer/media/peer_connection_identity_store.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/rtc_certificate_generator.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-chromium
Please have a look. This is a prerequisite of https://codereview.webrtc.org/1460043002/.
5 years, 1 month ago (2015-11-19 23:29:14 UTC) #3
tommi (sloooow) - chröme
lgtm
5 years, 1 month ago (2015-11-20 09:21:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461173002/1
5 years, 1 month ago (2015-11-20 09:52:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 10:17:59 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 10:18:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b854092fc667d594c9f31686a101067d74d7d6d7
Cr-Commit-Position: refs/heads/master@{#360794}

Powered by Google App Engine
This is Rietveld 408576698