Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: build/toolchain/nacl/BUILD.gn

Issue 1461163003: Removed debug symbols from Newlib PNaCl toolchain. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/nacl/BUILD.gn
diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn
index 2c641b1646b633795b4b8eb68eb1610797aa29da..48268ba6af9d2e94a2de5d37bbb6963b01950050 100644
--- a/build/toolchain/nacl/BUILD.gn
+++ b/build/toolchain/nacl/BUILD.gn
@@ -43,6 +43,11 @@ nacl_toolchain("newlib_pnacl") {
finalized_file = "{{root_out_dir}}/{{target_output_name}}.pexe"
postlink = "$finalize $nonfinal_file -o $finalized_file"
link_outputs = [ finalized_file ]
+
+ # TODO(smklein): Don't modify symbol_level from the default value once
+ # PNaCl's LLVM version has been updated to use more efficient debug info.
+ # See: https://github.com/domokit/mojo/issues/554
+ symbol_level = 0
}
nacl_toolchain("glibc_x86") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698