Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1461163002: Use std::tie() for operator< in extensions/ (Closed)

Created:
5 years, 1 month ago by jsbell
Modified:
5 years, 1 month ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::tie() for operator< in extensions/ Simplify the code for operator< when comparing multiple members using a common std::tie idiom. BUG=555171 R=rdevlin.cronin@chromium.org Committed: https://crrev.com/9a9ef2b842828e764ad7e120b6563025d27bdaad Cr-Commit-Position: refs/heads/master@{#360879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -58 lines) Patch
M extensions/browser/api/declarative/rules_registry_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/event_router.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M extensions/browser/process_map.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M extensions/common/permissions/socket_permission_entry.cc View 2 chunks +5 lines, -18 lines 0 comments Download
M extensions/common/permissions/usb_device_permission_data.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M extensions/renderer/user_script_injector.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jsbell
devlin - please take a look?
5 years, 1 month ago (2015-11-19 22:19:57 UTC) #1
Devlin
lgtm! So happy we can use this now.
5 years, 1 month ago (2015-11-20 01:19:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461163002/1
5 years, 1 month ago (2015-11-20 19:05:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 19:37:22 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 19:39:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a9ef2b842828e764ad7e120b6563025d27bdaad
Cr-Commit-Position: refs/heads/master@{#360879}

Powered by Google App Engine
This is Rietveld 408576698