Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1461143005: Use absolute path for deps in //components/BUILD.gn. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, tfarina
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use absolute path for deps in //components/BUILD.gn. Absolute paths are recommended and sort better, switch to absolute paths instead of relatives. BUG=None Committed: https://crrev.com/4ce5d79ac8257d7d04f8c3099e84558c162a45c6 Cr-Commit-Position: refs/heads/master@{#360989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M components/BUILD.gn View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-21 01:34:59 UTC) #2
Dirk Pranke
lgtm, thanks!
5 years, 1 month ago (2015-11-21 01:35:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461143005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461143005/1
5 years, 1 month ago (2015-11-21 01:38:31 UTC) #5
tfarina
lgtm, thanks!
5 years, 1 month ago (2015-11-21 02:07:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 02:44:59 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 02:45:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ce5d79ac8257d7d04f8c3099e84558c162a45c6
Cr-Commit-Position: refs/heads/master@{#360989}

Powered by Google App Engine
This is Rietveld 408576698