Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/clang/scripts/update.sh

Issue 1461003007: Roll clang 247874:253678 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/scripts/update.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.sh
diff --git a/tools/clang/scripts/update.sh b/tools/clang/scripts/update.sh
index 5cee97d8300cd6a82c5cefd46b550777f422bda5..cb344139ee5979ec98934151cfdd60072cc8ea7b 100755
--- a/tools/clang/scripts/update.sh
+++ b/tools/clang/scripts/update.sh
@@ -8,7 +8,7 @@
# Do NOT CHANGE this if you don't know what you're doing -- see
# https://code.google.com/p/chromium/wiki/UpdatingClang
# Reverting problematic clang rolls is safe, though.
-CLANG_REVISION=247874
+CLANG_REVISION=253678
# This is incremented when pushing a new build of Clang at the same revision.
CLANG_SUB_REVISION=1
@@ -548,12 +548,29 @@ mkdir -p "${COMPILER_RT_BUILD_DIR}"
pushd "${COMPILER_RT_BUILD_DIR}"
rm -fv CMakeCache.txt
-MACOSX_DEPLOYMENT_TARGET=${deployment_target} CC="" CXX="" cmake -GNinja \
+if [[ -z "${bootstrap}" ]]; then
+ # compiler_rt doesn't build with Xcode 6's clang, but not all bots have
+ # Xcode 7 yet. So use the just-built clang for building compiler-rt.
+ # However, in bootstrap builds, we delete libc++ to work around PR24068 -- so
+ # compiler_rt's CMake checks can't find <iostream> and decide that no arch
+ # is supported. So use the installed bootstrap compiler in bootstrap builds,
+ # it has the libc++ headers installed (CXX is already set to that in
+ # bootstrap builds).
+ CC="${ABS_LLVM_BUILD_DIR}/bin/clang"
+ CXX="${ABS_LLVM_BUILD_DIR}/bin/clang++"
+elif [[ "${OS}" = "Darwin" ]]; then
+ # ...except that compiler-rt currently doesn't build with the bootstrap
+ # compiler on Darwin either! So use the system compiler there.
+ # TOOD(thakis): Remove this once http://llvm.org/PR25465 is fixed.
+ CC=cc
+ CXX=c++
+fi
+MACOSX_DEPLOYMENT_TARGET=${deployment_target} cmake -GNinja \
-DCMAKE_BUILD_TYPE=Release \
-DLLVM_ENABLE_ASSERTIONS=ON \
-DLLVM_ENABLE_THREADS=OFF \
- -DCMAKE_C_COMPILER="${ABS_LLVM_BUILD_DIR}/bin/clang" \
- -DCMAKE_CXX_COMPILER="${ABS_LLVM_BUILD_DIR}/bin/clang++" \
+ -DCMAKE_C_COMPILER="${CC}" \
+ -DCMAKE_CXX_COMPILER="${CXX}" \
-DSANITIZER_MIN_OSX_VERSION="10.7" \
-DLLVM_CONFIG_PATH="${ABS_LLVM_BUILD_DIR}/bin/llvm-config" \
"${ABS_COMPILER_RT_DIR}"
« no previous file with comments | « tools/clang/scripts/update.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698