Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1460983002: Expose GetLastCommitedOrigin() on WebContents and use it in about:blank (Closed)

Created:
5 years, 1 month ago by upendrag.gowda
Modified:
4 years, 8 months ago
CC:
chromium-reviews, msramek+watch_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, raymes+watch_chromium.org, darin-cc_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose GetLastCommitedOrigin() on WebContents and use it in about:blank site identity. Expose GetLastCommittedOrigin() on content::WebContents and display it in about:blank page's site identity when it is opened by another frame. Screenshot: https://code.google.com/p/chromium/issues/detail?id=469889#c48 BUG=469889, 498580, 466422 R=meacer@chromium.org,felt@chromium.org,nasko@chromium.org,creis@chromium.org TBR=cpu@chromium.org TEST=Start Chrome. Navigate to google.com (or any website). Run 'window.open()' from the page. Bring up the Chrome Security UI bubble. (Its disabled right now, you need to enable it locally) Site identity section should show origin as opener's host.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M content/public/browser/web_contents.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
upendrag.gowda
5 years, 1 month ago (2015-11-19 03:54:34 UTC) #2
felt
upendrag.gowda: I hate to be the bearer of bad news, but the connection panel of ...
5 years, 1 month ago (2015-11-19 05:32:39 UTC) #4
lgarron
On 2015/11/19 at 05:32:39, felt wrote: > upendrag.gowda: I hate to be the bearer of ...
4 years, 9 months ago (2016-03-17 00:06:19 UTC) #5
meacer
On 2016/03/17 00:06:19, lgarron wrote: > On 2015/11/19 at 05:32:39, felt wrote: > > upendrag.gowda: ...
4 years, 9 months ago (2016-03-17 00:08:26 UTC) #6
upendrag.gowda
On 2016/03/17 00:08:26, Mustafa Emre Acer wrote: > On 2016/03/17 00:06:19, lgarron wrote: > > ...
4 years, 9 months ago (2016-03-17 00:24:48 UTC) #7
meacer
On 2016/03/17 00:24:48, upendrag.gowda wrote: > On 2016/03/17 00:08:26, Mustafa Emre Acer wrote: > > ...
4 years, 9 months ago (2016-03-17 00:46:01 UTC) #8
upendrag.gowda
On 2016/03/17 00:46:01, Mustafa Emre Acer wrote: > On 2016/03/17 00:24:48, upendrag.gowda wrote: > > ...
4 years, 8 months ago (2016-04-07 17:40:59 UTC) #9
meacer
4 years, 8 months ago (2016-04-07 17:42:59 UTC) #10
On 2016/04/07 17:40:59, upendrag.gowda wrote:
> On 2016/03/17 00:46:01, Mustafa Emre Acer wrote:
> > On 2016/03/17 00:24:48, upendrag.gowda wrote:
> > > On 2016/03/17 00:08:26, Mustafa Emre Acer wrote:
> > > > On 2016/03/17 00:06:19, lgarron wrote:
> > > > > On 2015/11/19 at 05:32:39, felt wrote:
> > > > > > upendrag.gowda: I hate to be the bearer of bad news, but the
> connection
> > > > panel
> > > > > of the OIB is due to be deleted with Chrome 49. :( We replaced it with
> the
> > > new
> > > > > Security Panel, which was just launched with Chrome 48.
> > > > > > 
> > > > > > I think it would still be nice to incorporate the origin source
> > > information
> > > > > into the OIB. It just can't go into the connection tab, because that
is
> > > going
> > > > to
> > > > > be deleted.
> > > > > > 
> > > > > > lgarron, do you have any thoughts on where else the origin source
info
> > > could
> > > > > go in the OIB?
> > > > > 
> > > > > So, the connection tab is finally gone now.
> > > > > 
> > > > > However, the top of Page Info currently shows:
> > > > > 
> > > > >     about:blank
> > > > >     Your connection to this site is not private.
> > > > >     [Details]
> > > > > 
> > > > > As long as we still allow navigations to pages that show up with a URL
> of
> > > > > about:blank, I think it would be appropriate to update those strings
> > > instead.
> > > > > Perhaps:
> > > > > 
> > > > >     about:blank (http://google.com)
> > > > >     This page is opened and controlled by <ph
> > > > > name="DOMAIN">$1<ex>www.google.com</ex></ph>.
> > > > 
> > > > That sounds good to me.
> > > > @upendrag.gowda: Are you still interested in landing this patch?
> > > 
> > > Yes, I am interested. But I am not sure if I can take this up before March
> 30
> > (2
> > > weeks from now), since I have  project deadlines and midterms coming up.
Let
> > me
> > > know if that is OK for you.
> > 
> > SG, given that the bug has been open for a long time, I think it can wait
for
> > two more weeks.
> 
> Hi @meacer, I haven't been able to allocate time to work on this issue as
agreed
> before and it looks like the situation won't get any better for at least a
month
> as it's the end of semester. Please feel free to un-assign the task from me. 
> Apologies for the delay caused

No worries, palmer@ picked this up in another CL already:
https://codereview.chromium.org/1814993002/
Thanks for the heads up!

Powered by Google App Engine
This is Rietveld 408576698