Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1460933003: Remove mediastreamsignaling from libjingle build files (Closed)

Created:
5 years, 1 month ago by perkj_chrome
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mediastreamsignaling from libjingle build files + Add deadbeef@ as owner. + Remove hellner@ as owner. https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/source/talk/app/webrtc/mediastreamsignaling.h&l=28 Committed: https://crrev.com/7bbf1539d0cc8acbc9b6c9d1c1f3c2a9a3d7c608 Cr-Commit-Position: refs/heads/master@{#360574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/libjingle/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_chrome
please
5 years, 1 month ago (2015-11-19 12:41:43 UTC) #3
tommi (sloooow) - chröme
lgtm
5 years, 1 month ago (2015-11-19 12:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460933003/1
5 years, 1 month ago (2015-11-19 12:55:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 13:41:03 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 13:41:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bbf1539d0cc8acbc9b6c9d1c1f3c2a9a3d7c608
Cr-Commit-Position: refs/heads/master@{#360574}

Powered by Google App Engine
This is Rietveld 408576698