Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 146093006: Prompt for extension install on startup even when --force-app-mode is passed (Closed)

Created:
6 years, 10 months ago by James Cook
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Prompt for extension install on startup even when --force-app-mode is passed This ensures that extensions installed with --install-from-webstore still show an install prompt. BUG=342949 TEST=See bug for repro NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/extensions/startup_helper.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
James Cook
xiyuan, PTAL
6 years, 10 months ago (2014-02-12 00:37:15 UTC) #1
xiyuan
lgtm
6 years, 10 months ago (2014-02-12 01:18:33 UTC) #2
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 10 months ago (2014-02-12 17:07:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/146093006/1
6 years, 10 months ago (2014-02-12 17:08:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 17:32:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49835
6 years, 10 months ago (2014-02-12 17:32:15 UTC) #6
James Cook
asargent, can I get OWNERS?
6 years, 10 months ago (2014-02-12 18:17:26 UTC) #7
asargent_no_longer_on_chrome
lgtm
6 years, 10 months ago (2014-02-12 22:58:58 UTC) #8
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 10 months ago (2014-02-13 00:30:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/146093006/1
6 years, 10 months ago (2014-02-13 00:33:01 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 00:56:08 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49961
6 years, 10 months ago (2014-02-13 00:56:09 UTC) #12
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 10 months ago (2014-02-13 01:15:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/146093006/1
6 years, 10 months ago (2014-02-13 01:17:14 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 01:35:55 UTC) #15
Message was sent while issue was closed. 
Change committed as 250900

Powered by Google App Engine
This is Rietveld 408576698