Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1460923004: [Sync] Disable failing TwoClientTypedUrlsSyncTest E2ETest (Closed)

Created:
5 years, 1 month ago by shadi
Modified:
5 years ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Disable failing TwoClientTypedUrlsSyncTest E2ETest This change affects E2ETests only, the test is still enabled on chromium waterfalls. BUG=559250 Committed: https://crrev.com/6ccf5fd5ca8ee56e0de7f1b768a7e904662edc85 Cr-Commit-Position: refs/heads/master@{#361385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
shadi
PTAL
5 years, 1 month ago (2015-11-20 19:11:21 UTC) #2
shadi
PTAL
5 years, 1 month ago (2015-11-20 22:07:17 UTC) #5
Nicolas Zea
Is this still necessary? This should be fixed server side now right?
5 years, 1 month ago (2015-11-23 23:09:58 UTC) #6
Nicolas Zea
lgtm
5 years, 1 month ago (2015-11-24 01:07:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460923004/1
5 years ago (2015-11-24 17:33:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:06:02 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 18:06:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ccf5fd5ca8ee56e0de7f1b768a7e904662edc85
Cr-Commit-Position: refs/heads/master@{#361385}

Powered by Google App Engine
This is Rietveld 408576698