Chromium Code Reviews

Issue 1460873003: Fixing Authentication Dialog for Proxy Authentication. (Closed)

Created:
5 years, 1 month ago by svaldez
Modified:
4 years, 6 months ago
Reviewers:
vabr (Chromium), asanka, meacer
CC:
achuith+watch_chromium.org, chromium-reviews, dzhioev+watch_chromium.org, vabr+watchlistlogin_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing Authentication Dialog for Proxy Authentication. Adding strings for proxy authentication. BUG=49994 Committed: https://crrev.com/c41ed1abe28b265bf0bd776876127ed999f7f772 Cr-Commit-Position: refs/heads/master@{#360616}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+20 lines, -6 lines)
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments
M chrome/browser/ui/login/login_prompt.cc View 1 chunk +14 lines, -6 lines 1 comment

Messages

Total messages: 10 (4 generated)
svaldez
5 years, 1 month ago (2015-11-19 16:12:55 UTC) #2
vabr (Chromium)
LGTM, thanks! Vaclav
5 years, 1 month ago (2015-11-19 16:33:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460873003/1
5 years, 1 month ago (2015-11-19 16:35:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 17:35:28 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c41ed1abe28b265bf0bd776876127ed999f7f772 Cr-Commit-Position: refs/heads/master@{#360616}
5 years, 1 month ago (2015-11-19 17:36:39 UTC) #8
asanka
4 years, 6 months ago (2016-06-14 15:00:30 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1460873003/diff/1/chrome/browser/ui/login/log...
File chrome/browser/ui/login/login_prompt.cc (right):

https://codereview.chromium.org/1460873003/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_prompt.cc:134: authority, elided_realm);
The |authority| here is based on the request URL, not the proxy server. The
resulting prompt is unfortunately misleading. See issue 613626.

Powered by Google App Engine