Issue 1460863002: Redo the interface for capture stdio.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1460863002: Redo the interface for capture stdio. (Closed)

Created:
5 years, 1 month ago by turnidge

Modified:
5 years, 1 month ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Redo the interface for capture stdio. Flutter doesn't care to import tons of our include files. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b243fa53cfcaa9daf96fdf404ca5bbe27a83a3a0

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -28 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/bin/embedded_dart_io.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file.h	View		2 chunks	+0 lines, -16 lines	0 comments	Download
M	runtime/bin/file.cc	View	1 2	3 chunks	+26 lines, -7 lines	0 comments	Download
M	runtime/bin/main.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

turnidge

5 years, 1 month ago (2015-11-19 17:24:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
b243fa53cfcaa9daf96fdf404ca5bbe27a83a3a0 (presubmit successful).